[Mlir-commits] [mlir] [mlir][emitc] make CExpression trait into interface (PR #142771)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- mlir/include/mlir/Dialect/EmitC/IR/EmitCInterfaces.h mlir/include/mlir/Dialect/EmitC/IR/EmitC.h mlir/lib/Dialect/EmitC/IR/EmitC.cpp mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp mlir/lib/Dialect/EmitC/Transforms/Transforms.cpp mlir/lib/Target/Cpp/TranslateToCpp.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Target/Cpp/TranslateToCpp.cpp b/mlir/lib/Target/Cpp/TranslateToCpp.cpp
index fe2dfb260..067a0470b 100644
--- a/mlir/lib/Target/Cpp/TranslateToCpp.cpp
+++ b/mlir/lib/Target/Cpp/TranslateToCpp.cpp
@@ -329,8 +329,8 @@ static bool shouldBeInlined(ExpressionOp expressionOp) {
   if (hasDeferredEmission(user))
     return false;
 
-  // Do not inline expressions used by ops with the CExpressionInterface. If this
-  // was intended, the user could have been merged into the expression op.
+  // Do not inline expressions used by ops with the CExpressionInterface. If
+  // this was intended, the user could have been merged into the expression op.
   return !isa<emitc::CExpressionInterface>(*user);
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/142771