[Mlir-commits] [mlir] [MLIR] Determine contiguousness of memrefs with dynamic dimensions (PR #142421)

[Momchil Velikov]

================
@@ -838,6 +838,20 @@ def Builtin_MemRef : Builtin_Type<"MemRef", "memref", [
     ///
     bool areTrailingDimsContiguous(int64_t n);
 
+    /// Return the maximum number of trailing dimensions that can be
----------------
momchil-velikov wrote:

Now I think this member function better be named `getMaxContiguousTrailingDims`.

As for the range of return values, my impression is where we talk about collapsing we talk about
collapsing `d0, d1, d2, ..., dn-1` dimensions into a single new one, as opposed to collapsing `d1, d2, ..., dn-1` into `d0`, thus range `[0, n]` seems most appropriate.


https://github.com/llvm/llvm-project/pull/142421