[Mlir-commits] [mlir] [mlir][tensor] move tensor insert canonicalization to pattern (PR #142671)

[Mehdi Amini]

================
@@ -176,6 +176,9 @@ void populateFoldConstantExtractSlicePatterns(
           return false;
         });
 
+/// Patterns to fold inserts into a constant into a new constant.
+void populateFoldInsertAfterConstant(RewritePatternSet &patterns);
----------------
joker-eph wrote:

> Would it be OK to expose the single patterns in the header and have downstream users use the pattern?

Isn't this was you're doing here? This seems like what I'm objecting to actually: ad-hoc APIs exposing a zoo of patterns that downstream have to somehow managed to package together consistently?


https://github.com/llvm/llvm-project/pull/142671