[Mlir-commits] [mlir] [mlir][Affine] Handle null parent op in getAffineParallelInductionVarOwner (PR #142025)

[Han-Chung Wang]

hanhanW wrote:

@joker-eph many thanks for spending your time on this! I'm a little concerned about the change in transform ops because of this simple change. I did not find any use cases in the upstream repo, and I'm afraid that if it'd break other downstream projects. I'm not familiar with the setup, but we'd no longer be able to use it in `transform.apply_patterns`, right?

We also find a comment in TransformInterfaces.td that discourages non-conversion rewrite patterns in the transform op.

https://github.com/llvm/llvm-project/blob/7a80a8b2bc9136e5c6254eef68230a9b56b35779/mlir/include/mlir/Dialect/Transform/Interfaces/TransformInterfaces.td#L345-L355

For transform dialect test, I can follow up on it once we have better setup in upstream. My main goal of the PR is dropping the cherry-pick in our project, so I took a stab at writing the C++ pass. Hopefully, it can address your concern and other contributors can reuse the testing pass in the future, thanks!


https://github.com/llvm/llvm-project/pull/142025