[Mlir-commits] [mlir] Revert "Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags" (PR #142318)

Vitaly Buka llvmlistbot at llvm.org
Sun Jun 1 13:45:05 PDT 2025


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/142318

Reverts llvm/llvm-project#142210

This is not enough, see #141664

>From 5b9f877cdf1b9e22c501ae94d515b609f9d61ee5 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at gmail.com>
Date: Sun, 1 Jun 2025 13:44:36 -0700
Subject: [PATCH] Revert "Fixed wrong check
 OperationEquivalenceTest.HashWorksWithFlags (#142210)"

This reverts commit ab77a70a7441f52150694bddadcabd11f8d61533.
---
 mlir/unittests/IR/OperationSupportTest.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index 18ee9d71cb9fc..b18512817969e 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
   auto req2 = b.getI32IntegerAttr(60);
   Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
       b.getUnknownLoc(), req2, nullptr, nullptr, req2);
+  EXPECT_NE(getHash(op1, OperationEquivalence::None),
+            getHash(op2, OperationEquivalence::None));
   EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
             getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
-  EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
-            getHash(opWithProperty2, OperationEquivalence::None));
   opWithProperty1->destroy();
   opWithProperty2->destroy();
 }



More information about the Mlir-commits mailing list