[Mlir-commits] [mlir] [MLIR][Transform] Prefer entry points in current module (PR #151323)

[Jakub Kuderski]

================
@@ -121,23 +121,94 @@ ModuleOp transform::detail::getPreloadedTransformModule(MLIRContext *context) {
       ->getLibraryModule();
 }
 
+namespace {
+
+transform::TransformOpInterface
+findTransformEntryPointNonRecursive(Operation *op, StringRef entryPoint) {
----------------
kuhar wrote:

llvm prefers `static` functions over putting them in anonymous  namespaces.
```suggestion
static transform::TransformOpInterface
findTransformEntryPointNonRecursive(Operation *op, StringRef entryPoint) {
```

See https://llvm.org/docs/CodingStandards.html#restrict-visibility. In MLIR, we are less strict when it comes to keeping anonymous namespaces small, though.

https://github.com/llvm/llvm-project/pull/151323