[Mlir-commits] [mlir] [mlir][spirv] Fix UpdateVCEPass to deduce the correct set of capabilities (PR #151108)

[Davide Grohmann]

davidegrohmann wrote:

> I have merged the reverted PR, so buildbots should go back to being happy again. I guess we now can fix the issue and re-land this change? It'd be nice to get it to work with a single loop and container (if possible), but I don't mind having a less clever version that we know works. For what's worth I got this change running locally:
> 
> ```diff
> -  for (spirv::Capability cap : caps) {
> +  for (unsigned i = 0; i < caps.size(); ++i) {
> +    spirv::Capability cap = caps[i];
> ```
> 
> It seems to pass tests and Valgrind doesn't complain. But I'll let you take it from here. Also, I feel like this bug was sort of my fault so sorry for that :)

Thanks and no worries.
I have created a new PR with the above suggested change: https://github.com/llvm/llvm-project/pull/151502
I cannot really reproduce locally the same build with sanitizers as in CI. Is there an easy way to test that before merging?

https://github.com/llvm/llvm-project/pull/151108