[Mlir-commits] [flang] [mlir] [Flang][OpenMP] Fix to resolve the crash with SIMD aligned clause. (PR #150612)

[Tom Eccles]

https://github.com/tblah requested changes to this pull request.

Thanks for the fix.

I'm not sure about this approach. The warnings from the mlir to llvmir conversion will not be formatted as proper diagnostics and will not be controllable using the usual flags influencing other diagnostics.

Things like this should be done in flang semantic checks to ensure consistency.

It is good to catch this for other users of the OpenMP MLIR dialect too. In this case I would personally update the operation verifiers to not allow these unsupported alignment values.

https://github.com/llvm/llvm-project/pull/150612