[Mlir-commits] [mlir] [mlir][spirv] Fix UpdateVCEPass to deduce the correct set of capabilities (PR #151108)

Davide Grohmann llvmlistbot at llvm.org
Wed Jul 30 09:05:29 PDT 2025


davidegrohmann wrote:

> I think this is part of the problem; we probably should explicitly recalculate end iterator at every iteration: `for (auto I = caps.begin(); I != caps.end(); ++I)`. Also does `insert_range` append new elements to the end or can it add them somewhere else? That would also cause issues.
> 
> I think we should revert this PR and fix it without rushing. Are you able to hit revert or does it need commiter rights? If you can't do it, I can do it for you.

No I cannot revert patches.

https://github.com/llvm/llvm-project/pull/151108


More information about the Mlir-commits mailing list