[Mlir-commits] [mlir] [mlir][memref][spirv] Add SPIR-V Image Lowering (PR #150978)
Jack Frankland
llvmlistbot at llvm.org
Wed Jul 30 05:42:09 PDT 2025
================
@@ -661,6 +694,86 @@ LoadOpPattern::matchAndRewrite(memref::LoadOp loadOp, OpAdaptor adaptor,
return success();
}
+LogicalResult
+ImageLoadOpPattern::matchAndRewrite(memref::LoadOp loadOp, OpAdaptor adaptor,
+ ConversionPatternRewriter &rewriter) const {
+ auto memrefType = cast<MemRefType>(loadOp.getMemref().getType());
+
+ auto memorySpaceAttr =
+ dyn_cast_if_present<spirv::StorageClassAttr>(memrefType.getMemorySpace());
+ if (!memorySpaceAttr)
+ return rewriter.notifyMatchFailure(
+ loadOp, "missing memory space SPIR-V storage class attribute");
+
+ if (memorySpaceAttr.getValue() != spirv::StorageClass::Image)
+ return rewriter.notifyMatchFailure(
+ loadOp, "failed to lower memref in non-image storage class to image");
+
+ Value loadPtr = adaptor.getMemref();
+ auto memoryRequirements = calculateMemoryRequirements(loadPtr, loadOp);
+ if (failed(memoryRequirements))
+ return rewriter.notifyMatchFailure(
+ loadOp, "failed to determine memory requirements");
+
+ const auto [memoryAccess, alignment] = *memoryRequirements;
+
+ if (!loadOp.getMemRefType().hasRank())
+ return rewriter.notifyMatchFailure(
+ loadOp, "cannot lower unranked memrefs to SPIR-V images");
+
+ // We currently only support lowering of scalar memref elements to texels in
+ // the R[16|32][f|i|ui] formats. Future work will enable lowering of vector
+ // elements to texels in richer formats.
+ if (!loadOp.getMemRefType().getElementType().isIntOrFloat())
+ return rewriter.notifyMatchFailure(
+ loadOp, "cannot lower memrefs who's element type is not int or float "
+ "to SPIR-V images");
----------------
FranklandJack wrote:
Yes, makes way more sense, thanks!
https://github.com/llvm/llvm-project/pull/150978
More information about the Mlir-commits
mailing list