[Mlir-commits] [llvm] [mlir] Reland "[mlir][llvm] Add intrinsic arg and result attribute support (… (PR #151125)

[Tobias Gysi]

gysit wrote:

> But, could you also add a sentence to say what's different between this and the previous attempt? "this reverts commit bla to reland bla but with X added or moved or whatever it is".

Good point!

The two revisions have the following difference:

In the definition of `ArgAndResultAttrsOpInterface` that can be found in `mlir/include/mlir/Interfaces/CallInterfaces.td` the original PR accidentally uses:

`list<InterfaceMethod> methods = [`

Instead of of just:

`let methods =[`

I changed this in the reland PR. My understanding is that let should be used here to overwrite the method field which is defined in the tablegen base class the interface is deriving from.




https://github.com/llvm/llvm-project/pull/151125