[Mlir-commits] [mlir] [mlir][IR] Add `getPropertyAsAttr` and `setPropertyFromAttr` methods. (PR #150060)

[Krzysztof Drewniak]

krzysz00 wrote:

> Also worth asking as part of this or future conversation, is it still worth it to support generic format and unregistered ops?

Generic format is useful for cases where the pninting logic relies on the verifier.

Also, an unregistered operation has a fairly clean property storage, which is *almost* what's implemented.

The properties storage is a string => Attribute dictionary, getPropertyAsAttr() / setPropertyAsAttr() become operations on that dictionary (which can accept arbitrary keys).

(The current implementation basically does this, except that it uses a `DictionaryAttr`, but that's details)

https://github.com/llvm/llvm-project/pull/150060