[Mlir-commits] [mlir] [mlir][vector] vector.splat deprecation: folding/canonicalizing parity with broadcast (PR #150284)

[Andrzej Warzyński]

================
@@ -1288,19 +1288,46 @@ LogicalResult vector::ExtractElementOp::verify() {
   return success();
 }
 
+/// Consider the defining operation `defOp` of `value`. If `defOp` is a
+/// vector.splat or a vector.broadcast with a scalar operand, return the scalar
+/// value that is splatted. Otherwise return null.
+///
+/// Cases where null is not returned:
----------------
banach-space wrote:

[nit] This sentence reads a bit like "cases where this won't work", but the actual examples show cases where this does indeed work.
```suggestion
/// Examples:
```

https://github.com/llvm/llvm-project/pull/150284