[Mlir-commits] [mlir] [mlir][EmitC]Add a Reflection Map to a Class (PR #150572)

[Mircea Trofin]

mtrofin wrote:

> > The map should be declared as a member of the class.
> 
> We could:
> 
> 1. Declare the map as a member of the class, pass it as an argument to the function then return it from the function or
> 2. Initialize the map within the function and return it from the function.

Let's do 1. 2 would mean re-creating the map at every call to that function, which would need to be renamed to indicate that (`create` not `get`), but more importantly, it's not necessary to re-create the map as the data inside of it doesn't change and shouldn't change.

https://github.com/llvm/llvm-project/pull/150572