[Mlir-commits] [mlir] [mlir][llvm] Add intrinsic arg and result attribute support (PR #150783)

[Benjamin Maxwell]

================
@@ -1758,6 +1758,48 @@ ModuleTranslation::convertParameterAttrs(LLVMFuncOp func, int argIdx,
   return attrBuilder;
 }
 
+LogicalResult ModuleTranslation::convertArgAndResultAttrs(
+    ArgAndResultAttrsOpInterface attrsOp, llvm::CallBase *call,
+    ArrayRef<unsigned> immArgPositions) {
+  // Convert the argument attributes.
+  if (ArrayAttr argAttrsArray = attrsOp.getArgAttrsAttr()) {
+    unsigned argAttrIdx = 0;
+    llvm::DenseSet<unsigned> immArgPositionsSet(immArgPositions.begin(),
----------------
MacDue wrote:

nit: For consistency with `convertArgAndResultAttrs`
```suggestion
    llvm::SmallDenseSet<unsigned> immArgPositionsSet(immArgPositions.begin(),
```

https://github.com/llvm/llvm-project/pull/150783