[Mlir-commits] [mlir] [mlir][NFC] update `mlir/Dialect` create APIs (33/n) (PR #150659)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Jul 25 10:20:01 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- mlir/lib/Dialect/AMX/IR/AMXDialect.cpp mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp mlir/lib/Dialect/Bufferization/Transforms/LowerDeallocations.cpp mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp mlir/lib/Dialect/GPU/Transforms/ShuffleRewriter.cpp mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp mlir/lib/Dialect/MemRef/Transforms/IndependenceTransforms.cpp mlir/lib/Dialect/MemRef/Transforms/RuntimeOpVerification.cpp mlir/lib/Dialect/Quant/Transforms/LowerQuantOps.cpp mlir/lib/Dialect/SCF/Transforms/BufferizableOpInterfaceImpl.cpp mlir/lib/Dialect/SCF/Utils/Utils.cpp mlir/lib/Dialect/Shape/IR/Shape.cpp mlir/lib/Dialect/Shard/Transforms/Partition.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseGPUCodegen.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseIterationToScf.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp mlir/lib/Dialect/Tensor/Transforms/IndependenceTransforms.cpp mlir/lib/Dialect/Tensor/Transforms/ReshapePatterns.cpp mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeDepthwise.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Dialect/AMX/IR/AMXDialect.cpp b/mlir/lib/Dialect/AMX/IR/AMXDialect.cpp
index 8c1786d3f..6f3110cdf 100644
--- a/mlir/lib/Dialect/AMX/IR/AMXDialect.cpp
+++ b/mlir/lib/Dialect/AMX/IR/AMXDialect.cpp
@@ -97,7 +97,7 @@ static Value getStride(Location loc, MemRefType mType, Value base,
auto attr = rewriter.getI64IntegerAttr(bytes);
Value scale = LLVM::ConstantOp::create(rewriter, loc, llvmInt64Type, attr);
return LLVM::MulOp::create(rewriter, loc, llvmInt64Type, scale,
- memrefDescriptor.stride(rewriter, loc, preLast))
+ memrefDescriptor.stride(rewriter, loc, preLast))
.getResult();
}
// Use direct constant for static stride.
diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
index 3a49bf01a..f7b0b8708 100644
--- a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
+++ b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
@@ -688,7 +688,8 @@ FailureOr<Value> bufferization::getBuffer(RewriterBase &rewriter, Value value,
if (failed(bufferType))
return failure();
ensureToBufferOpIsValid(value, *bufferType);
- return bufferization::ToBufferOp::create(rewriter, value.getLoc(), *bufferType, value)
+ return bufferization::ToBufferOp::create(rewriter, value.getLoc(),
+ *bufferType, value)
.getResult();
}
@@ -772,7 +773,7 @@ FailureOr<Value> BufferizationOptions::createAlloc(OpBuilder &b, Location loc,
// Default bufferallocation via AllocOp.
if (bufferAlignment != 0)
return memref::AllocOp::create(b, loc, type, dynShape,
- b.getI64IntegerAttr(bufferAlignment))
+ b.getI64IntegerAttr(bufferAlignment))
.getResult();
return memref::AllocOp::create(b, loc, type, dynShape).getResult();
}
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/LowerDeallocations.cpp b/mlir/lib/Dialect/Bufferization/Transforms/LowerDeallocations.cpp
index 8b8f14456..e9ad13f7e 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/LowerDeallocations.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/LowerDeallocations.cpp
@@ -482,9 +482,10 @@ func::FuncOp mlir::bufferization::buildDeallocationLibraryFunction(
// Build the first for loop that computes aliasing with retained
// memrefs.
- Value noRetainAlias =
- scf::ForOp::create(builder,
- loc, c0, toRetainSize, c1, trueValue,
+ Value
+ noRetainAlias =
+ scf::ForOp::create(
+ builder, loc, c0, toRetainSize, c1, trueValue,
[&](OpBuilder &builder, Location loc, Value i,
ValueRange iterArgs) {
Value retainValue = memref::LoadOp::create(
@@ -511,13 +512,14 @@ func::FuncOp mlir::bufferization::buildDeallocationLibraryFunction(
builder, loc, iterArgs[0], doesntAlias);
scf::YieldOp::create(builder, loc, yieldValue);
})
- .getResult(0);
+ .getResult(0);
// Build the second for loop that adds aliasing with previously
// deallocated memrefs.
- Value noAlias =
- scf::ForOp::create(builder,
- loc, c0, outerIter, c1, noRetainAlias,
+ Value
+ noAlias =
+ scf::ForOp::create(
+ builder, loc, c0, outerIter, c1, noRetainAlias,
[&](OpBuilder &builder, Location loc, Value i,
ValueRange iterArgs) {
Value prevDeallocValue = memref::LoadOp::create(
@@ -529,7 +531,7 @@ func::FuncOp mlir::bufferization::buildDeallocationLibraryFunction(
builder, loc, iterArgs[0], doesntAlias);
scf::YieldOp::create(builder, loc, yieldValue);
})
- .getResult(0);
+ .getResult(0);
Value shouldDealoc = arith::AndIOp::create(builder, loc, noAlias, cond);
memref::StoreOp::create(builder, loc, shouldDealoc, deallocCondsMemref,
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp b/mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp
index 5af63d478..725fa2429 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp
@@ -750,16 +750,16 @@ Value BufferDeallocation::materializeMemrefWithGuaranteedOwnership(
// Insert a runtime check and only clone if we still don't have ownership at
// runtime.
- Value maybeClone = scf::IfOp::create(builder,
- memref.getLoc(), condition,
- [&](OpBuilder &builder, Location loc) {
- scf::YieldOp::create(builder, loc, newMemref);
- },
- [&](OpBuilder &builder, Location loc) {
- Value clone = bufferization::CloneOp::create(
- builder, loc, newMemref);
- scf::YieldOp::create(builder, loc, clone);
- })
+ Value maybeClone = scf::IfOp::create(
+ builder, memref.getLoc(), condition,
+ [&](OpBuilder &builder, Location loc) {
+ scf::YieldOp::create(builder, loc, newMemref);
+ },
+ [&](OpBuilder &builder, Location loc) {
+ Value clone = bufferization::CloneOp::create(
+ builder, loc, newMemref);
+ scf::YieldOp::create(builder, loc, clone);
+ })
.getResult(0);
Value trueVal = buildBoolValue(builder, memref.getLoc(), true);
state.updateOwnership(maybeClone, trueVal);
diff --git a/mlir/lib/Dialect/GPU/Transforms/ShuffleRewriter.cpp b/mlir/lib/Dialect/GPU/Transforms/ShuffleRewriter.cpp
index dd0ae6a04..8e0543615 100644
--- a/mlir/lib/Dialect/GPU/Transforms/ShuffleRewriter.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/ShuffleRewriter.cpp
@@ -61,11 +61,11 @@ struct GpuShuffleRewriter : public OpRewritePattern<gpu::ShuffleOp> {
// Shuffle the values.
ValueRange loRes =
gpu::ShuffleOp::create(rewriter, op.getLoc(), lo, op.getOffset(),
- op.getWidth(), op.getMode())
+ op.getWidth(), op.getMode())
.getResults();
ValueRange hiRes =
gpu::ShuffleOp::create(rewriter, op.getLoc(), hi, op.getOffset(),
- op.getWidth(), op.getMode())
+ op.getWidth(), op.getMode())
.getResults();
// Convert lo back to i64.
diff --git a/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp b/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
index 37fd0bf32..b45fdf34e 100644
--- a/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
@@ -198,8 +198,8 @@ Value createSubgroupShuffleReduction(OpBuilder &builder, Location loc,
for (unsigned i = ci.clusterStride; i < ci.clusterStride * ci.clusterSize;
i <<= 1) {
Value shuffled = gpu::ShuffleOp::create(builder, loc, packFn(laneVal), i,
- /*width=*/ci.subgroupSize,
- /*mode=*/gpu::ShuffleMode::XOR)
+ /*width=*/ci.subgroupSize,
+ /*mode=*/gpu::ShuffleMode::XOR)
.getShuffleResult();
laneVal = vector::makeArithReduction(builder, loc,
gpu::convertReductionKind(mode),
diff --git a/mlir/lib/Dialect/Shape/IR/Shape.cpp b/mlir/lib/Dialect/Shape/IR/Shape.cpp
index 50985c1c1..5ba828918 100644
--- a/mlir/lib/Dialect/Shape/IR/Shape.cpp
+++ b/mlir/lib/Dialect/Shape/IR/Shape.cpp
@@ -1703,7 +1703,7 @@ struct ShapeOfOpToConstShapeOp : public OpRewritePattern<shape::ShapeOfOp> {
Location loc = op.getLoc();
Value constShape =
ConstShapeOp::create(rewriter, loc,
- rewriter.getIndexTensorAttr(type.getShape()))
+ rewriter.getIndexTensorAttr(type.getShape()))
.getResult();
if (constShape.getType() != op.getResult().getType())
constShape = tensor::CastOp::create(rewriter, loc,
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
index 505f83d5b..79f4e7f67 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
@@ -904,8 +904,8 @@ public:
dstTp->withoutDimToLvl(),
!srcTp->isAllOrdered() || !srcTp->isIdentity() || !dstTp->isIdentity());
SmallVector<Value> dynSizes;
- Value buffer = AllocTensorOp::create(rewriter, loc, bufferTp, dynSizes, Value(),
- nnz, Attribute())
+ Value buffer = AllocTensorOp::create(rewriter, loc, bufferTp, dynSizes,
+ Value(), nnz, Attribute())
.getResult();
// Convert src coordinates to dst coordinates by first collapsing it to 1D
@@ -1013,7 +1013,7 @@ public:
Value buffer =
AllocTensorOp::create(rewriter, loc, bufferTp, dstDynSizes, Value(),
- /*sizeHint=*/nnz, Attribute())
+ /*sizeHint=*/nnz, Attribute())
.getResult();
// Implement the sparse2sparse reshape as follows:
``````````
</details>
https://github.com/llvm/llvm-project/pull/150659
More information about the Mlir-commits
mailing list