[Mlir-commits] [mlir] [MLIR][TOSA] Update IfOp print/parse to support ranked condition tens… (PR #149791)

[Yuvaraj Venkatesh]

Yuvaraj-Venkatesh wrote:

> Thanks for the updates @Yuvaraj-Venkatesh! Apologies, I took another look and picked up some things I missed the first time round. Could we also add some positive test cases to check the improved functionality?:
> 
> * One to check that the shape of the condition is retained after parse/print round-trip
> * One to check that the block arguments are retained after parse/print round-trip
> 
> Since the cond_if validation check is now merged, it would be good to update this comment: https://github.com/llvm/llvm-project/pull/143772/files#diff-9094a3c264abb63100ab95e0e9e6d5c303b346ec9926b814e58b50ffaa1253e0R1235 as part of this change as well.
> 
> Since this change potentially impacts downstream users, tagging a few more people that might be interested: @sjarus @GeorgeARM @amirBish @udaya-ranga

Thanks @lhutton1!
I’ve added a couple of positive test cases and updated the comments in the validation logic as well.

https://github.com/llvm/llvm-project/pull/149791