[Mlir-commits] [mlir] [mlir][NFC] update `mlir/Dialect` create APIs (17/n) (PR #149924)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Jul 24 12:22:00 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp mlir/lib/Dialect/Linalg/Transforms/BufferizableOpInterfaceImpl.cpp mlir/lib/Dialect/Linalg/Transforms/ConvertConv2DToImg2Col.cpp mlir/lib/Dialect/Linalg/Transforms/ConvertToDestinationStyle.cpp mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp mlir/lib/Dialect/Linalg/Transforms/DecomposeLinalgOps.cpp mlir/lib/Dialect/Linalg/Transforms/Detensorize.cpp mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp mlir/lib/Dialect/Linalg/Transforms/ElementwiseToLinalg.cpp mlir/lib/Dialect/Linalg/Transforms/EraseUnusedOperandsAndResults.cpp mlir/lib/Dialect/Linalg/Transforms/FusePadOpWithLinalgProducer.cpp mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp mlir/lib/Dialect/Linalg/Transforms/Generalization.cpp mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp mlir/lib/Dialect/Linalg/Transforms/InlineScalarOperands.cpp mlir/lib/Dialect/Linalg/Transforms/Interchange.cpp mlir/lib/Dialect/Linalg/Transforms/Loops.cpp mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp mlir/lib/Dialect/Linalg/Transforms/NamedOpConversions.cpp mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp mlir/lib/Dialect/Linalg/Transforms/PadTilingInterface.cpp mlir/lib/Dialect/Linalg/Transforms/Padding.cpp mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp mlir/lib/Dialect/Linalg/Transforms/RuntimeOpVerification.cpp mlir/lib/Dialect/Linalg/Transforms/Split.cpp mlir/lib/Dialect/Linalg/Transforms/SplitReduction.cpp mlir/lib/Dialect/Linalg/Transforms/SwapExtractSliceWithFillPatterns.cpp mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp mlir/lib/Dialect/Linalg/Transforms/TransposeConv2D.cpp mlir/lib/Dialect/Linalg/Transforms/TransposeMatmul.cpp mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp mlir/lib/Dialect/Linalg/Utils/Utils.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp b/mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp
index 91cc12964..745a40dbc 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp
@@ -566,7 +566,7 @@ linalg::dropUnitDims(RewriterBase &rewriter, GenericOp genericOp,
resultTypes.push_back(newOutputs[i].getType());
GenericOp replacementOp =
GenericOp::create(b, loc, resultTypes, newInputs, newOutputs,
- newIndexingMaps, newIteratorTypes);
+ newIndexingMaps, newIteratorTypes);
b.cloneRegionBefore(genericOp.getRegion(), replacementOp.getRegion(),
replacementOp.getRegion().begin());
// 5a. Replace `linalg.index` operations that refer to the dropped unit
diff --git a/mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp b/mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp
index 753f824dd..83d12e314 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/MeshShardingInterfaceImpl.cpp
@@ -194,9 +194,9 @@ static void createAllReduceForResultsWithoutPartialShardings(
llvm::zip_equal(unshardedOp->getResults(), resultShardings)) {
Value spmdizedLinalgOpResult =
spmdizationMap.lookup(unshardedLinalgOpResult);
- Value reducedValue = mesh::AllReduceOp::create(builder,
- spmdizedLinalgOpResult, resultSharding.getMesh(), opReductionMeshAxes,
- reductionKind);
+ Value reducedValue = mesh::AllReduceOp::create(
+ builder, spmdizedLinalgOpResult, resultSharding.getMesh(),
+ opReductionMeshAxes, reductionKind);
spmdizationMap.map(unshardedLinalgOpResult, reducedValue);
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/149924
More information about the Mlir-commits
mailing list