[Mlir-commits] [mlir] [mlir][linalg] Restrict linalg.pack to not have artificial padding. (PR #149624)

[llvmlistbot at llvm.org]

================
@@ -150,9 +150,10 @@ def Linalg_PackOp : Linalg_RelayoutOp<"pack", [
 
     `padding_value` specifies a padding value at the boundary on non-perfectly
     divisible dimensions. Padding is optional:
-    - If absent, it is UB if the tile does not perfectly divide the dimension.
+    - If absent, it assumes the tile perfectly divides the dimension.
     - If present, it will pad along high dimensions (high-padding) to make the
-      tile complete.
+      tile complete. Note that it is not allowed to have artificial padding that
+      is not strictly required by linalg.pack.
----------------
Max191 wrote:

It sounds a little unclear to me what "artificial padding" is. I know what it is because I have the context, but it might not be well-defined enough for new contributors. Maybe you could add something like:
```suggestion
      tile complete. Note that it is not allowed to have artificial padding that
      is not strictly required by linalg.pack (i.e., padding past what is needed
      to complete the last tile along each packed dimension).
```

https://github.com/llvm/llvm-project/pull/149624