[Mlir-commits] [mlir] [mlir][NFC] update `mlir/Dialect` create APIs (19/n) (PR #149926)
Maksim Levental
llvmlistbot at llvm.org
Tue Jul 22 05:59:29 PDT 2025
makslevental wrote:
> Did you use a sed command for this, can you post it here for posterity?
`(\w)\.create<(.*?)>\(`
I'm curious why you chose to break this down into quite so many PRs (26?) , wouldn't it be more straightforward to run the regex on the whole project, once, and post a single PR?
To make each chunk reviewable so that if the regex did something wrong we had a chance of catching it.
>
> btw thanks a million for this change, I'm looking forward to not using the convoluted `OpName::build(` workaround for getting signatures described in the editor!
👍
https://github.com/llvm/llvm-project/pull/149926
More information about the Mlir-commits
mailing list