[Mlir-commits] [mlir] [mlir][EmitC]Expand the MemRefToEmitC pass - Lowering `AllocOp` (PR #148257)
Gil Rapaport
llvmlistbot at llvm.org
Tue Jul 22 04:20:52 PDT 2025
================
@@ -77,6 +77,43 @@ struct ConvertAlloca final : public OpConversionPattern<memref::AllocaOp> {
}
};
+struct ConvertAlloc final : public OpConversionPattern<memref::AllocOp> {
+ using OpConversionPattern::OpConversionPattern;
+ LogicalResult
+ matchAndRewrite(memref::AllocOp allocOp, OpAdaptor operands,
+ ConversionPatternRewriter &rewriter) const override {
+ mlir::Location loc = allocOp.getLoc();
+ auto memrefType = allocOp.getType();
+ if (!memrefType.hasStaticShape())
+ // TODO: Handle Dynamic shapes in the future. If the size
+ // of the allocation is the result of some function, we could
+ // potentially evaluate the function and use the result in the call to
+ // allocate.
+ return rewriter.notifyMatchFailure(
+ allocOp.getLoc(), "cannot transform alloc op with dynamic shape");
+
+ // TODO: Is there a better API to determine the number of bits in a byte in
+ // MLIR?
+ int64_t totalSize = memrefType.getNumElements() *
+ memrefType.getElementTypeBitWidth() / CHAR_BIT;
+ if (auto alignment = allocOp.getAlignment()) {
+ int64_t alignVal = alignment.value();
+ totalSize = (totalSize + alignVal - 1) / alignVal * alignVal;
----------------
aniragil wrote:
> If we have non-standard alignment requirements, `aligned_alloc()` is perhaps the better choice?
+1.
IINM `aligned_alloc()` is standard since C11 and C++17, so we might produce code that won't compile, but this is in general the current state of things - the code lowered to EmitC determines the target C/C++ variant as specified by the dialect's documentation (patch will need to add this case to the docs). And as long as we only use it for non-standard alignment we can keep the C target constraint to a minimum.
https://github.com/llvm/llvm-project/pull/148257
More information about the Mlir-commits
mailing list