[Mlir-commits] [mlir] [mlir][linalg] Restrict linalg.pack to not have artificial padding. (PR #149624)

[Adam Siemieniuk]

================
@@ -150,9 +150,10 @@ def Linalg_PackOp : Linalg_RelayoutOp<"pack", [
 
     `padding_value` specifies a padding value at the boundary on non-perfectly
     divisible dimensions. Padding is optional:
-    - If absent, it is UB if the tile does not perfectly divide the dimension.
+    - If absent, it assumes the tile perfectly divides the dimension.
     - If present, it will pad along high dimensions (high-padding) to make the
-      tile complete.
+      tile complete. Note that it is not allowed to have artificial padding that
+      is not strictly required by linalg.pack.
----------------
adam-smnk wrote:

For static it's easy to verify.
For dynamically shaped source, `linalg::lowerPack` doesn't respect that i.e., extra padding will be applied.

Not sure if it's really a problem but FYI.

https://github.com/llvm/llvm-project/pull/149624