[Mlir-commits] [mlir] [MLIR] Add shape propagation through tensor.pad (PR #136681)

[Andrzej Warzyński]

banach-space wrote:

Thanks for contributing! I have two high-level asks.

> [iree-org/iree#17492 (comment)](https://github.com/iree-org/iree/issues/17492#issuecomment-2688799803)

ASK 1: Please use the summary to describe and to justify your change (i.e. provide rationale). The summary should be self-contained and shouldn't refer to any external projects (within reason, but in this case I don't find the reference helpful). You could, for example, explain why "bubbling up" `tensor.extract_shape`  from your example is desirable.

> 
> I’ve implemented fusion for tensor.{collapse_shape,expand_shape} → tensor.pad.
> 
> Before (expand then pad):
> 
> (...)
> 
> After (reshape then pad):
> 

ASK 2: "Before" and "after" _what_? Could you clarify?

Thanks!

https://github.com/llvm/llvm-project/pull/136681