[Mlir-commits] [mlir] [mlir] update LLVM create APIs (2/n) (PR #149667)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat Jul 19 11:18:04 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp mlir/lib/Dialect/LLVMIR/IR/FunctionCallUtils.cpp mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp mlir/lib/Dialect/LLVMIR/IR/LLVMMemorySlot.cpp mlir/lib/Dialect/LLVMIR/Transforms/AddComdats.cpp mlir/lib/Dialect/LLVMIR/Transforms/InlinerInterfaceImpl.cpp mlir/lib/Dialect/LLVMIR/Transforms/LegalizeForExport.cpp mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index bef60e7be..e6a661926 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -4379,8 +4379,8 @@ Value mlir::LLVM::createGlobalString(Location loc, OpBuilder &builder,
   OpBuilder moduleBuilder(module.getBodyRegion(), builder.getListener());
   MLIRContext *ctx = builder.getContext();
   auto type = LLVM::LLVMArrayType::get(IntegerType::get(ctx, 8), value.size());
-  auto global = LLVM::GlobalOp::create(moduleBuilder,
-      loc, type, /*isConstant=*/true, linkage, name,
+  auto global = LLVM::GlobalOp::create(
+      moduleBuilder, loc, type, /*isConstant=*/true, linkage, name,
       builder.getStringAttr(value), /*alignment=*/0);
 
   LLVMPointerType ptrType = LLVMPointerType::get(ctx);
@@ -4388,7 +4388,7 @@ Value mlir::LLVM::createGlobalString(Location loc, OpBuilder &builder,
   Value globalPtr =
       LLVM::AddressOfOp::create(builder, loc, ptrType, global.getSymNameAttr());
   return LLVM::GEPOp::create(builder, loc, ptrType, type, globalPtr,
-                                     ArrayRef<GEPArg>{0, 0});
+                             ArrayRef<GEPArg>{0, 0});
 }
 
 bool mlir::LLVM::satisfiesLLVMModule(Operation *op) {
diff --git a/mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp b/mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp
index de6c3043b..7f34f7d14 100644
--- a/mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp
+++ b/mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp
@@ -68,19 +68,19 @@ LogicalResult ExpandDivF16::matchAndRewrite(LLVM::FDivOp op,
 
   // Refine the approximation with one Newton iteration:
   // float refined = approx + (lhs - approx * rhs) * rcp;
-  Value err = LLVM::FMAOp::create(rewriter,
-      loc, approx, LLVM::FNegOp::create(rewriter, loc, rhs), lhs);
+  Value err = LLVM::FMAOp::create(
+      rewriter, loc, approx, LLVM::FNegOp::create(rewriter, loc, rhs), lhs);
   Value refined = LLVM::FMAOp::create(rewriter, loc, err, rcp, approx);
 
   // Use refined value if approx is normal (exponent neither all 0 or all 1).
-  Value mask = LLVM::ConstantOp::create(rewriter,
-      loc, i32Type, rewriter.getUI32IntegerAttr(0x7f800000));
+  Value mask = LLVM::ConstantOp::create(
+      rewriter, loc, i32Type, rewriter.getUI32IntegerAttr(0x7f800000));
   Value cast = LLVM::BitcastOp::create(rewriter, loc, i32Type, approx);
   Value exp = LLVM::AndOp::create(rewriter, loc, i32Type, cast, mask);
-  Value zero = LLVM::ConstantOp::create(rewriter,
-      loc, i32Type, rewriter.getUI32IntegerAttr(0));
-  Value pred = LLVM::OrOp::create(rewriter,
-      loc,
+  Value zero = LLVM::ConstantOp::create(rewriter, loc, i32Type,
+                                        rewriter.getUI32IntegerAttr(0));
+  Value pred = LLVM::OrOp::create(
+      rewriter, loc,
       LLVM::ICmpOp::create(rewriter, loc, LLVM::ICmpPredicate::eq, exp, zero),
       LLVM::ICmpOp::create(rewriter, loc, LLVM::ICmpPredicate::eq, exp, mask));
   Value result =

``````````

</details>


https://github.com/llvm/llvm-project/pull/149667


More information about the Mlir-commits mailing list