[Mlir-commits] [mlir] [MLIR][SCF] Add dedicated Python bindings for ForallOp (PR #149416)

[Maksim Levental]

makslevental wrote:

> For example the existing for_ helper with the argument yielding lives alongside the ForOp class which has more properties you can access.

Yes of course having what you've contributed here is good as far as providing access to attributes and etc but what I'm saying is if you provide the `scf.ForAllOp.terminator` API then if/when I/we/you introduce the `for x in scf.forall` pattern and people try to emit a terminator in the body using the `.terminator()` method it'll be incompatible with the generator.

Ok having said that I think I'm being unnecessarily cautious because in that pattern there's actually not even a way to access the class instance itself. So nevermind my that complaint - your version is good to land 😄 

The only thing I'll say is that you haven't handled `shared_outs` which I handled in my version:

```python
class ForallOp(ForallOp):
    def __init__(
        ...
        shared_outs: Optional[Union[Operation, OpView, Sequence[Value]]] = None,
        ...
    ):
        ...
        if shared_outs is not None:
            results = [o.type for o in shared_outs]
        else:
            results = shared_outs = []
        ...

        super().__init__(
            ...
            outputs=shared_outs,
            ...
        )
```

Can you add that?

https://github.com/llvm/llvm-project/pull/149416