[Mlir-commits] [mlir] [mlir] Deprecate OpPrintingFlags(std::nullopt_t) (NFC) (PR #149546)

[Kazu Hirata]

================
@@ -1175,6 +1175,7 @@ class alignas(8) OperandStorage {
 class OpPrintingFlags {
 public:
   OpPrintingFlags();
+  LLVM_DEPRECATED("Use OpPrintingFlags() instead", "OpPrintingFlags()")
   OpPrintingFlags(std::nullopt_t) : OpPrintingFlags() {}
----------------
kazutakahirata wrote:

Thanks for the review!  Hmm.  `{}` is short.  `OpPrintingFlags()` is descriptive. `nullptr_t` is neither short nor descriptive.  `nullptr_t` would work well in the perfect-forwarding context, however.

https://github.com/llvm/llvm-project/pull/149546