[Mlir-commits] [llvm] [mlir] [MLIR][Wasm] Introduce the WasmSSA MLIR dialect (PR #149233)

[Renato Golin]

https://github.com/rengolin commented:

This looks more or less like I expected, which is mostly boilerplate for the new dialect. My only concern is that this PR adds a lot of operations but only tests a minor section of them. Not sure if more tests will be added later, but it's not clear from the description if that's the case, or a priority.

Given that there's no syntax helper on the ops description, a test file per op would not only be good engineering practice but also give us an idea how the dialect is represented.

https://github.com/llvm/llvm-project/pull/149233