newling wrote: @gysit Thank you for reviewing this! I think I have addressed your comments. The one I'm not sure about is the removal of TensorType from the new static function, `getElementType`. Please see my inline comment. https://github.com/llvm/llvm-project/pull/148975