[Mlir-commits] [mlir] [MLIR] Fix use-after-free in DistinctAttr when using crash recovery (PR #148666)

[Mehdi Amini]

joker-eph wrote:

> A thread local cache, for this use case, only makes sense if the thread pool is alive during the entire lifetime of the mlir context.

Do you mean "storage" instead of "cache" here? (to me a per-thread **cache** is always fine because it stays private to the thread).

It seems that there is a deeper problem with this storage to address than what this PR is trying to do then! 

https://github.com/llvm/llvm-project/pull/148666