[Mlir-commits] [mlir] [MLIR] Fix use-after-free in DistinctAttr when using crash recovery (PR #148666)

[Mehdi Amini]

joker-eph wrote:

@gysit : you implemented this `DistinctAttributeAllocator`, I don't quite get the invariant right now.
For example what happens if I run a pass manager with a thread-pool, then disable multi-threading. Isn't this destroying the threads and thus the thread-local storages? Would that break the IR?
I'm not sure because it is using a `ThreadLocalCache` which is intended a per-thread **cache** and not a primary storage solution, but it seems that this isn't what is done here?

https://github.com/llvm/llvm-project/pull/148666