[Mlir-commits] [mlir] 1db33f1 - [mlir][Transforms] Report all `allowPatternRollback` violations as fatal errors (#148416)

[llvmlistbot at llvm.org]

Author: Matthias Springer
Date: 2025-07-13T17:41:21+02:00
New Revision: 1db33f1034aa758ff7a04d09641232d2ce1a2a2b

URL: https://github.com/llvm/llvm-project/commit/1db33f1034aa758ff7a04d09641232d2ce1a2a2b
DIFF: https://github.com/llvm/llvm-project/commit/1db33f1034aa758ff7a04d09641232d2ce1a2a2b.diff

LOG: [mlir][Transforms] Report all `allowPatternRollback` violations as fatal errors (#148416)

Report all `allowPatternRollback` API violations as fatal errors. If
violated, the IR is potentially in an invalid/inconsistent state from
which the driver cannot recover.

Added: 
    

Modified: 
    mlir/lib/Transforms/Utils/DialectConversion.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 437dbcfea5288..4d01a83d37165 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2266,9 +2266,8 @@ OperationLegalizer::legalizeWithPattern(Operation *op,
     appliedPatterns.erase(&pattern);
     if (failed(result)) {
       if (!rewriterImpl.config.allowPatternRollback)
-        op->emitError("pattern '")
-            << pattern.getDebugName()
-            << "' produced IR that could not be legalized";
+        llvm::report_fatal_error("pattern '" + pattern.getDebugName() +
+                                 "' produced IR that could not be legalized");
       rewriterImpl.resetState(curState, pattern.getDebugName());
     }
     if (config.listener)