[Mlir-commits] [mlir] Expand the MemRefToEmitC pass - Adding scalars (PR #148055)

[Paul Kirth]

================
@@ -41,6 +41,8 @@ func.func @memref_load(%buff : memref<4x8xf32>, %i: index, %j: index) -> f32 {
 module @globals {
   memref.global "private" constant @internal_global : memref<3x7xf32> = dense<4.0>
   // CHECK-NEXT: emitc.global static const @internal_global : !emitc.array<3x7xf32> = dense<4.000000e+00>
+  memref.global "private" constant @__constant_xi32 : memref<i32> = dense<-1>
----------------
ilovepi wrote:

I was expecting to see a corresponding change to `memref-to-emitc-failed.mlir`. Looking I suppose it isn't there, but are any of the cases, like https://github.com/llvm/llvm-project/blob/36b61a6b5731a524b4e79e77d7505c7a5ef3d0f9/mlir/test/Conversion/MemRefToEmitC/memref-to-emitc-failed.mlir#L46 going to work now?

https://github.com/llvm/llvm-project/pull/148055