[Mlir-commits] [mlir] [mlir][tblgen] add concrete create methods (PR #147168)

[Mehdi Amini]

joker-eph wrote:

> I haven't followed completely here, but what is the reason for generating create methods specifically for ImplicitOpBuilder? Is this something that will need to be or should be generalized? I suppose this is to just remove the need for an extra Location argument? Is that right/it?

It wouldn't be necessary if not to elide the location argument I believe.
That means if you start typing `Op::create(builder, ` and your builder is not an ImplicitLocBuilder you will get the completion only starting with the loc.
Annoyingly I suspect that with an ImplicitLocBuilder it will still offer the overloads with the location argument, since the ImplicitLocBuilder would match as an `OpBuilder &` as well.

https://github.com/llvm/llvm-project/pull/147168