[Mlir-commits] [mlir] [mlir][LLVMIR] Add IFuncOp to LLVM dialect (PR #147697)

[Tobias Gysi]

https://github.com/gysit commented:

Nice! Thanks for adding ifuncs.

The direction looks good module some nits. The tests need a bit more work though. The current ones are a bit long and could probably be simplified? Additionally, adding some tests for the verifiers (invalid.mlir) and possibly some roundtrip tests for the custom printing and parsing would make sense.

https://github.com/llvm/llvm-project/pull/147697