[Mlir-commits] [mlir] [mlir][vector] Refactor WarpOpScfForOp to support unused or swapped forOp results. (PR #147620)

[Charitha Saumya]

charithaintc wrote:

> The transformation looks correct to me, nice! Wouldn't we need basically the same thing for other scf ops? Seems like this can be generalized.

Thanks for the review Peter. Currently we don't have support for other scf ops (like scf.if, scf.while) which we may need later. I will think about generalization steps once we have more use cases for these ops. But appreciate your suggestion. This pattern is very complex to begin with, so some kind of abstraction to deal with these moving parts will def help. 


https://github.com/llvm/llvm-project/pull/147620