[Mlir-commits] [mlir] Silence MLIRTargetLLVMTests failures pre-ROCm6.4 (PR #147610)

[Fabian Mora]

https://github.com/fabianmcg requested changes to this pull request.

Not blocking on the merits of the patch. Just preventing merging until we agree on the path forward.

Can you expand a bit more on the issue? For example, what happens if you compile with ROCm 6.4 or later?

What about adding a CMake flag like `MLIR_DEFAULT_ROCM_ABI=600` controlled by the detected ROCm version and substituting it here https://github.com/rengolin/llvm-project/commit/84cb08e11866dda721e9a1b5a39c4e963fc36c32#diff-3da7b8747032bb581f119fd49037d06706443c3c5db56d4d28cc74053a9b754dL189  ?

https://github.com/llvm/llvm-project/pull/147610