[Mlir-commits] [flang] [mlir] [mlir][tblgen] add concrete create methods (PR #147168)

[Oleksandr Alex Zinenko]

ftynse wrote:

> Overall I'd like to hear more about this from @jpienaar @ftynse @j2kun (maybe @Mogball and @River707 ?) : are we OK to transition from builder.create<Op>(...) to Op::create(builder, ...) for the benefit of better IDE support?

I'd be very happy to transition! I can offer some help if needed.

Strategically, I think this still needs a dedicated forum post for visibility, even though it appears there is consensus in this thread. The post should include instructions for downstreams on how to transition.

I'd also like to deprecate and remove the previous style of builders _eventually_, following the same consistency arguments as @joker-eph. At the very least for upstream usage. Given the importance of this particular API, I'd say we could deprecate after the next release branches, and remove one or two releases after that. Maybe there'a a way to have a GitHub action check new commits for the `create<` string and notify about the preferred upstream style as a way of soft deprecation. This is something to discuss on the forum, no particular rush IMO. 

https://github.com/llvm/llvm-project/pull/147168