[Mlir-commits] [mlir] [MLIR] [Vector] Linearization patterns for vector.load and vector.store (PR #145115)

[Nishant Patel]

nbpatel wrote:

> What should be happening if one of the outer dims != 1? This is a general design question.
>  
> Could you add some negative tests? Also, this should work for scalable vectors provided that there is only one scalable dim. Would you mind taking care of that as well? Thanks!

Hey Andrzej, I was on vacation for past two weeks and hence the delay in the response.

1. My understanding is the user can use the unrolling patterns for load and store to get to the vector<1x...xN> form if one of the outer dim is not 1 and then use the linearization patterns to linearize it. 

2. For negative cases, the tests will error out currently with legalization error, so not sure what is the correct way to add them. I don't see any other ops having negative tests. @newling ? 

3. I added the check and test case for scalable dim. Please take a look.

Thanks.

https://github.com/llvm/llvm-project/pull/145115