[Mlir-commits] [mlir] [mlir][tblgen] add concrete create methods (PR #147168)

[Mehdi Amini]

joker-eph wrote:

> Is deprecating the current usage necessary?

Upstream, I would say yes: consistency is important in the codebase IMO: having to completely equivalent way of writing it is hurting readability and accessibility to the codebase.
We don't have to actually deprecate it in the sense of "add a compiler warning that affects all users" and "we will remove this API in a future release". We could just document the old one as "this API exists for historical reasons, we advise people to use `Op::create(...)` instead".



https://github.com/llvm/llvm-project/pull/147168