[Mlir-commits] [mlir] [mlir][spirv] Add basic support for SPV_EXT_replicated_composites (PR #147067)

[Igor Wodiany]

https://github.com/IgWod-IMG commented:

Thank you for submitting this PR. Few general and specific comments from me:

1. We probably should also add tests to: https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/SPIRV/IR/availability.mlir

2. I wonder whether it would make sense to add some tests to https://github.com/llvm/llvm-project/tree/main/mlir/test/Dialect/SPIRV/IR including some negative tests?

3. Regarding the use of braces; I feel like in some places they could be dropped. See: https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements But leave the decision up to you.

https://github.com/llvm/llvm-project/pull/147067