[Mlir-commits] [mlir] [mlir][tblgen] add concrete create methods (PR #147168)

[Mehdi Amini]

https://github.com/joker-eph commented:

Seems like a reasonable incremental change on the current state (not too far from the current syntax), preserving compatibility with existing builders (important since they can be handwritten today).
It does not close the door to moving to another pattern (like the fluent API that is explored, or something else).

It's a bit annoying that people would wonder why they would see in the codebase either `builder.create<Op>(...)` or `Op::create(builder, ...)`. We're losing consistency and I would rather not. I'm not sure if we should have a coding guideline: plan to migrate to this new pattern and ultimately deprecating `builder.create<Op<(...)` (at least upstream)?


https://github.com/llvm/llvm-project/pull/147168