[Mlir-commits] [mlir] [mlir][vector][memref] Add `alignment` attribute to memory access ops (PR #144344)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for updating the summary, that makes a lot of sense to me 🙏🏻 

> 4. Retire memref.assume_alignment op.

I'm not quite sure whether we have agreement on this? I do support it though and am happy for you to keep it there. 

All in all, LGTM, but I left a few nits to improve our testing "hygiene". Nothing major. I will "approve" once that's addressed.

Thanks for working on this!

https://github.com/llvm/llvm-project/pull/144344