[Mlir-commits] [mlir] [mlir][TosaToLinalg] Ensure valid insertion pointer after op erasure (PR #146908)

[Andrzej Warzyński]

banach-space wrote:

Thanks for the fix!

> I tried this https://github.com/llvm/llvm-project/pull/146955 but it makes op erasure more expensive. What do you think?

Personally I feel that updating the insertion point should remain the responsibility of the user. Looking at this specific example, it feels like `ewriter.replaceOp(op, resultOp);` is invoked pre-maturely.

This is just an opinion, I don't have any data for or against a particular approach.

https://github.com/llvm/llvm-project/pull/146908