[Mlir-commits] [mlir] [mlir][AffineExpr] Order arguments in the commutative affine exprs (PR #146895)

[Quinn Dawkins]

qedawkins wrote:

> > Rather than swapping while constructing expressions, can we do this during simplifyAdd/simplifyMul? Having the operands of an expression you just created get swapped sounds surprising to me.
> 
> I kind of don't like how `simplifyMul` calls constructor (and thus itself) recursively, you can end up with infinite recursion if not careful.

Ouch, that does sounds bad, ok makes sense to me.

https://github.com/llvm/llvm-project/pull/146895