[Mlir-commits] [mlir] [mlir][spirv] Add basic support for SPV_EXT_replicated_composites (PR #147067)

[Jakub Kuderski]

================
@@ -678,6 +678,14 @@ spirv::Deserializer::getConstant(uint32_t id) {
   return constIt->getSecond();
 }
 
+std::optional<std::pair<uint32_t, Type>>
+spirv::Deserializer::getConstantCompositeReplicate(uint32_t id) {
+  auto constIt = constantCompositeReplicateMap.find(id);
+  if (constIt == constantCompositeReplicateMap.end())
+    return std::nullopt;
+  return constIt->getSecond();
----------------
kuhar wrote:

nit: I'd define `it` in the if condition itself and flip the check:
```suggestion
  if (auto it = constantCompositeReplicateMap.find(id); it != constantCompositeReplicateMap.end())
    return it->second;
  return std::nullopt;
```

https://github.com/llvm/llvm-project/pull/147067