[Mlir-commits] [mlir] [mlir][OpenMP] Don't allow firstprivate for simd (PR #146734)

[Sergio Afonso]

================
@@ -326,6 +326,25 @@ static LogicalResult checkImplementationStatus(Operation &op) {
     if (op.getDistScheduleChunkSize())
       result = todo("dist_schedule with chunk_size");
   };
+  auto checkFirstprivate = [&todo](auto op, LogicalResult &result) {
----------------
skatrak wrote:

Rather than checking this here, perhaps the MLIR op verifier (`SimdOp::verify`) would be a better place to do it. Otherwise, if a frontend produced an invalid MLIR where `omp.simd` took a `firstprivate` privatizer argument, it would be reported as not-yet-implemented when it's actually an invalid condition.

https://github.com/llvm/llvm-project/pull/146734