[Mlir-commits] [mlir] [mlir] NFC: void visitRegionSuccessors (PR #125268)

Mehdi Amini llvmlistbot at llvm.org
Fri Jan 31 11:16:56 PST 2025


joker-eph wrote:

Making a method virtual is not a trivial change: it at minima deserves to update the document IMO.

In particular the dataflow framework is already a complex piece of of machinery that is hard to grasp, every new customization point increases the complexity, and should be described in terms of the invariant of the system (what is an implemented overriding this allowed to do here and for which purposes?).

https://github.com/llvm/llvm-project/pull/125268


More information about the Mlir-commits mailing list