[Mlir-commits] [mlir] cf8c730 - Fix LinalgOps build error on older clang versions

[llvmlistbot at llvm.org]

Author: erichkeane
Date: 2025-01-31T06:31:44-08:00
New Revision: cf8c730ce931e0a38ce4bfd00660c5eacf10d992

URL: https://github.com/llvm/llvm-project/commit/cf8c730ce931e0a38ce4bfd00660c5eacf10d992
DIFF: https://github.com/llvm/llvm-project/commit/cf8c730ce931e0a38ce4bfd00660c5eacf10d992.diff

LOG: Fix LinalgOps build error on older clang versions

As reported in the PR #123618, 0d4efa27252cbbea4b56 included a
construction of a `FailureOr` object with a `nullptr`, which didn't work
in at least clang-10.  This patch changes it into a constructor call
instead of a brace-init call so that it is unambiguous.

Added: 
    

Modified: 
    mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
index b33ba1cfb87dc47..2f1c22b10dd36f9 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
@@ -3533,7 +3533,8 @@ bool MatmulOp::isValidLhsRhsBroadcastMap(AffineMap bcastMap) {
 
 FailureOr<ArrayAttr> parseIndexingMapsAttr(OpAsmParser &parser) {
   if (parser.parseOptionalKeyword("indexing_maps"))
-    return {nullptr}; // Success in case indexing_maps was not provided.
+    return ArrayAttr{
+        nullptr}; // Success in case indexing_maps was not provided.
 
   ArrayAttr arrayAttr;
   if (parser.parseEqual() || parser.parseAttribute(arrayAttr))