[Mlir-commits] [mlir] [MLIR][doc] Fix docs for IRDL using -gen-dialect-doc (PR #125195)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-irdl

Author: Thomas Preud'homme (RoboTux)

<details>
<summary>Changes</summary>

mlir-tblgen fails to generate doc for IRDL because while parsing IRDL.td
it also finds the definition of the builtin dialect and cannot determine
what dialect to generate documentation for. This is because IRDL.td
includes IRDLOps.td which includes BuiltinAttributes.td which in turns
includes BuiltinDialect.td.


---
Full diff: https://github.com/llvm/llvm-project/pull/125195.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt
index ec3e06bedae038..861db0ca96671d 100644
--- a/mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/IRDL/IR/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_mlir_dialect(IRDL irdl)
-add_mlir_doc(IRDLOps IRDL Dialects/ -gen-dialect-doc)
+add_mlir_doc(IRDLOps IRDL Dialects/ -gen-dialect-doc -dialect=irdl)
 
 # Add IRDL interfaces
 set(LLVM_TARGET_DEFINITIONS IRDLInterfaces.td)

``````````

</details>


https://github.com/llvm/llvm-project/pull/125195