[Mlir-commits] [mlir] [MLIR][LLVM] Import LLVM target triple into MLIR LLVM Dialect (PR #125084)

[Tobias Gysi]

https://github.com/gysit approved this pull request.

Thanks, LGTM.

I think it is ok to have a separate function for the target triple import similar to the data layout import. 

With regards to the data layout vs target triple discussion, I am in favor of keeping them separate to mirror LLVM IR. Usually, LLVM dialect tries to follow LLVM IR as closely as possible. However, I agree that there is room for improving the representation of the target triple in LLVM dialect (currently it is a string attribute). 







https://github.com/llvm/llvm-project/pull/125084